Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
website_urlwhen website analysis (onboarding step 2) exists so clients get a consistent field.404instead of allowing unexpected 500s.Description
current_user: dict = Depends(get_current_user)to/,/website-url, and/onboardingendpoints and extractuser_id = str(current_user.get("id"))for all service calls.user_idexplicitly intoUserDataService.get_user_onboarding_data(user_id)andget_user_website_url(user_id).UserDataService.get_user_website_urlsignature to requireuser_id: strand removed the defaultuser_id=1assumption, and updated the integration call to use the explicit ID.HTTPException(status_code=404)when onboarding data is absent, re-raisesHTTPExceptioncleanly, ensuresdb_sessionis closed, and injects a top-levelwebsite_urlinto responses when awebsite_analysisexists.Testing
python -m py_compile backend/api/user_data.py backend/services/user_data_service.pywhich completed successfully.Codex Task